Updated setup.cfg with check-manifest #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanketh7
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
taylorfturner
added
the
High Priority
|
@Sanketh7 needs an |
taylorfturner
previously requested changes
Nov 2, 2022
MANIFEST.in
Outdated
Comment on lines
15
to
17
| recursive-include examples *.ipynb | ||
| recursive-include examples *.md | ||
| recursive-include examples *.png |
There was a problem hiding this comment.
concerned these are included in the installation... they shouldn't be
There was a problem hiding this comment.
that is ipynb, md, and png
There was a problem hiding this comment.
if I take them out I receive
missing from sdist:
examples/DL-Flowchart.png
examples/add_new_model_to_data_labeler.ipynb
examples/column_name_labeler.ipynb
examples/data_profiler_demo.ipynb
examples/data_readers.ipynb
examples/graph_data_demo.ipynb
examples/great_expecations/README.md
examples/great_expecations/ge_expect_column_value_confidence_for_data_label.ipynb
examples/great_expecations/ge_expect_column_values_vs_profile_min.ipynb
examples/great_expecations/ge_expect_profile_numeric_columns_diff_in_range.ipynb
examples/great_expecations/ge_expect_profile_numeric_columns_percent_diff_in_range.ipynb
examples/intro_data_profiler.ipynb
examples/labeler.ipynb
examples/merge_profile_list.ipynb
examples/popmon_dp_loader_example.ipynb
examples/regex_labeler_from_scratch/DataLabeler_from_scratch.ipynb
examples/structured_profilers.ipynb
examples/unstructured_profilers.ipynb
and check-manifest recommends adding those 3 lines (15 - 17)
Comment on lines
+48
to
+57
| # Check-manifest: ensures required non-Python files are included in MANIFEST.in | ||
| # https://github.com/mgedmin/check-manifest/blob/master/.pre-commit-hooks.yaml | ||
| - repo: https://github.com/mgedmin/check-manifest | ||
| rev: "0.48" | ||
| hooks: | ||
| - id: check-manifest | ||
| additional_dependencies: ['h5py', 'wheel', 'future', 'numpy', 'pandas', | ||
| 'python-dateutil', 'pytz', 'six', 'pyarrow', 'chardet', 'fastavro', | ||
| 'python-snappy', 'charset-normalizer', 'psutil', 'scipy', 'requests', | ||
| 'networkx','typing-extensions'] |
There was a problem hiding this comment.
run check-manifest on pre-commit run
setup.cfg
Outdated
Comment on lines
17
to
21
| DataProfiler.egg-info/** | ||
| dataprofiler/reports/.mypy_cache/** | ||
| dataprofiler/tests/data/json/honeypot | ||
| dataprofiler/labelers/embeddings/glove-reduced-64D.txt | ||
| resources/__pycache__/__init__.cpython** |
There was a problem hiding this comment.
had to add these for check-manifest to pass
There was a problem hiding this comment.
that is lines 17 - 21
taylorfturner
added
New Feature
| @@ -1,3 +1,4 @@ | |||
| check-manifest>=0.48 | |||
There was a problem hiding this comment.
adding new dependency of check-manifest for pre-commit
Comment on lines
+54
to
+57
| additional_dependencies: ['h5py', 'wheel', 'future', 'numpy', 'pandas', | ||
| 'python-dateutil', 'pytz', 'six', 'pyarrow', 'chardet', 'fastavro', | ||
| 'python-snappy', 'charset-normalizer', 'psutil', 'scipy', 'requests', | ||
| 'networkx','typing-extensions'] |
There was a problem hiding this comment.
have to add these for check-manifest to run in the pre-commit environment
There was a problem hiding this comment.
read this but was reading a post from the creator of pre-commit that using -r requirements.txt in the add_dependencies is not good practice
JGSweets
approved these changes
Nov 2, 2022
ksneab7
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
check-manifestas hook forpre-commit