Merge pull request #78 from capitalone/feature/py38compat

Avoid compiler warnings about PyObject_GC_UnTrack
capitalone · May 27, 2020 · 53dbcb0 · 53dbcb0
2 parents b36ce85 + 6ac2fbe
commit 53dbcb0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/giraffez/src/_compat.h b/giraffez/src/_compat.h
@@ -89,7 +89,9 @@
 #endif    
 
 #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 6
-  #define _PyObject_GC_UNTRACK PyObject_GC_UnTrack
+  #define _PyObject_GC_UnTrack PyObject_GC_UnTrack
+#else
+  #define _PyObject_GC_UnTrack _PyObject_GC_UNTRACK 
 #endif
 
 #if defined(WIN32) || defined(WIN64)

diff --git a/giraffez/src/convert.c b/giraffez/src/convert.c
@@ -895,7 +895,7 @@ int _clz(uint32_t x) {
 
 PyObject* teradata_number_from_pystring(PyObject *item, unsigned char **buf, uint16_t *packed_length) {
     char *s;
-    int i, j, sign = 0, b, r, count = 0;
+    int i, sign = 0, b, r, count = 0;
     PyObject *n, *nn = NULL, *str, *zero, *mask, *shift;
     int8_t length = 0;
     int16_t scale = 0;

diff --git a/giraffez/src/errors.c b/giraffez/src/errors.c
@@ -85,7 +85,7 @@ static int TeradataError_clear(TeradataErrorObject *self) {
 }
 
 static void TeradataError_dealloc(TeradataErrorObject *self) {
-    _PyObject_GC_UNTRACK(self);
+    _PyObject_GC_UnTrack(self);
     TeradataError_clear(self);
     Py_TYPE(self)->tp_free((PyObject*)self);
 }