Specify the minimum supported Rust version for capnp crate #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSRV (minimum supported Rust version) is the earliest version capable of building a project. In the case of the capnp crate, the MSRV is 1.65.0, due to the use of GATs. Having the MSRV in Cargo.toml helps display better error messages when the Rust version is too old to build a project. eg: > error: package `capnp v0.15.0 (/Users/maxime/Code/capnproto-rust/capnp)` > cannot be built because it requires rustc 1.65.0 or newer, while the > currently active rustc version is 1.64.0 Without it, the error messages are more confusing. > error[E0658]: generic associated types are unstable > --> capnp/src/traits.rs:73:5 > | > 73 | type Builder<'a>: FromStructBuilder<'a> + HasStructSize; > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > | > = note: see issue #44265 <rust-lang/rust#44265> for more information Cargo.toml docs: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
punkeel
force-pushed
the
punkeel/msrv
branch
from
35cc823
to
ae314cd
Compare
|
Oh, cool. Looks like that field got added in rust-lang/cargo#9732. |
|
Thanks! |
|
Just noting for completeness here: we do have a CI job that makes sure we don't accidentally break support on older rust versions: capnproto-rust/.github/workflows/ci.yml Line 14 in 89f9e52 |
ErikMcClure
pushed a commit
to Fundament-Software/capstone-rs
that referenced
this pull request
Mar 25, 2024
Specify the minimum supported Rust version for capnp crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSRV (minimum supported Rust version) is the earliest version capable of building a project. In the case of the capnp crate, the MSRV is 1.65.0, due to the use of GATs.
Having the MSRV in Cargo.toml helps display better error messages when the Rust version is too old to build a project. eg:
Without it, the error messages are more confusing.
Cargo.toml docs: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
I'm only adding this to the
capnpcrate, ascapnpc/capnp-rpc/capnp-futuresall depend on it.