Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against newer Node.js versions #1144

Closed
IGx89 opened this issue Oct 26, 2023 · 0 comments · Fixed by #1145
Closed

Run tests against newer Node.js versions #1144

IGx89 opened this issue Oct 26, 2023 · 0 comments · Fixed by #1145
Labels
enhancement New feature or request

Comments

@IGx89
Copy link
Contributor

IGx89 commented Oct 26, 2023

The pull request workflow is currently running tests only against an EOL Node.js version, 16. Tests ideally should be run against the current LTS version (20) as well as the last LTS version (18) to ensure this library continues to properly support them as well.
@IGx89 IGx89 added the enhancement New feature or request label Oct 26, 2023
IGx89 added a commit to IGx89/happy-dom that referenced this issue Oct 26, 2023
@IGx89
capricorn86#1144@patch: Run tests against newer Node.js versions
a0a4954 
Also fixed tests that were failing locally for me (running on Node.js 18), for various reasons.
@IGx89 IGx89 mentioned this issue Oct 26, 2023
Merged
IGx89 added a commit to IGx89/happy-dom that referenced this issue Oct 26, 2023
@IGx89
capricorn86#1144@patch: Add continue-on-error.
676e313
IGx89 added a commit to IGx89/happy-dom that referenced this issue Oct 26, 2023
@IGx89
capricorn86#1144@patch: Fix flaky test.
a35f7b2
IGx89 added a commit to IGx89/happy-dom that referenced this issue Oct 26, 2023
@IGx89
capricorn86#1144@patch: Fix test on Node 20.
f26b084
capricorn86 added a commit to IGx89/happy-dom that referenced this issue Oct 27, 2023
@capricorn86
capricorn86#1144@trivial: Updates Date ISO week function to a more ba…
49d489d 
…ttle tested.
capricorn86 added a commit to IGx89/happy-dom that referenced this issue Oct 27, 2023
@capricorn86
capricorn86#1144@trivial: Updates Date ISO week function to a more ba…
a56ed6a 
…ttle tested.
capricorn86 added a commit that referenced this issue Oct 27, 2023
@capricorn86
Merge pull request #1145 from IGx89/task/test-newer-node-versions
9a0062b 
#1144@patch: Run tests against newer Node.js versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1144@patch: Run tests against newer Node.js versions IGx89/happy-dom
1 participant
@IGx89