Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update invoiceninja One Click App #1099

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

julianengel
Copy link
Contributor

@julianengel julianengel commented May 2, 2024

-> Bumped to latest version
-> Updated descriptions to be more clear
-> Added email env variables to main app
-> Added variables for GoCardless and enabling the banking integration

Addresses issue raised in: #1047

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

-> Bumped to latest version
-> Updated descriptions to be more clear
-> Added email env variables to main app
-> Added variables for GoCardless and enabling the banking integration
In the DB setup, it said Invoice Ninja's which accidentally broke the YAML file. Reworded it to The Invoice Ninja Admin Password.
@githubsaturn
Copy link
Collaborator

Thanks for the PR! Looks like formatter is failing, please run this to fix the issue:

npm ci && npm run formatter-write

@julianengel
Copy link
Contributor Author

Hey @githubsaturn! Thanks so much :) That's weird, I ran it before doing the PR, and also ran it just now and it comes out clean. I also tested it as One Click App with the template, and it deployed without issue.

Attached the output:


> [email protected] formatter-write
> prettier --write "./public/**/*.(json|yml)"

public/v4/apps/imagor-local.yml 1ms
public/v4/apps/imagor-s3.yml 3ms
public/v4/apps/imgproxy.yml 2ms
public/v4/apps/immich.yml 3ms
public/v4/apps/influxdb.yml 3ms
public/v4/apps/influxdb2.yml 2ms
public/v4/apps/invidious.yml 4ms
public/v4/apps/invoiceninja.yml 5ms
public/v4/apps/invoiceplane.yml 3ms
public/v4/apps/iredmail.yml 5ms
public/v4/apps/jellyfin.yml 2ms
public/v4/apps/jenkins.yml 2ms

@githubsaturn
Copy link
Collaborator

You've probably used a different version of the prettifier.

Try this:

npm -rf node_modules
npm ci # this ensures the exact same version to be installed
npm run formatter-write

@julianengel
Copy link
Contributor Author

julianengel commented May 3, 2024 via email

@githubsaturn
Copy link
Collaborator

Hmm... that's weird... Anyways, I can merge and fix it later.

@githubsaturn githubsaturn merged commit 5693974 into caprover:master May 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants