Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOST (GO Simple Tunnel) v2 & v3 #1119

Merged
merged 7 commits into from
Jun 23, 2024
Merged

Conversation

amirsaam
Copy link
Contributor

@amirsaam amirsaam commented Jun 18, 2024

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@amirsaam amirsaam changed the title Add GOST (GO Simple Tunnel) Add GOST (GO Simple Tunnel) v2 Jun 18, 2024
@amirsaam amirsaam changed the title Add GOST (GO Simple Tunnel) v2 Add GOST (GO Simple Tunnel) v2 & v3 Jun 19, 2024
@githubsaturn
Copy link
Collaborator

Build is failing. Make sure the file extensions are .yml - You can manually run validator and formatter to make sure the build passes.

@amirsaam
Copy link
Contributor Author

@githubsaturn that was my mistake, fixed it.

@githubsaturn
Copy link
Collaborator

Build is still failing. Make sure to run npm run formatter-write and it'll take care of formatting.

@amirsaam
Copy link
Contributor Author

amirsaam commented Jun 23, 2024

@githubsaturn build should be fixed by now, sorry for being a newbie

@githubsaturn
Copy link
Collaborator

Thanks!

@githubsaturn githubsaturn merged commit cadd6d2 into caprover:master Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants