add PostHog #1145
Merged
add PostHog #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public/v4/apps/posthog.yml
Outdated
| caproverExtra: | ||
| notExposeAsWebApp: 'true' | ||
| dockerfileLines: | ||
| - FROM andremoura/helper AS helper |
There was a problem hiding this comment.
This has an implicit latest tag, can you please ensure a concrete version here?
|
|
||
| instructions: | ||
| start: >- | ||
| Enter your PostHog Configuration parameters and click on next. The process will take a just a few minutes to finish. |
There was a problem hiding this comment.
This is one of the most complex apps that we have in the repo. Can you please add a suggested minimum hardware requirement for this suite of apps?
Also, maybe add a note saying that "this one click app deploys 16 distinct apps and it requires ....."
githubsaturn
reviewed
Sep 2, 2024
public/v4/apps/posthog.yml
Outdated
| caproverExtra: | ||
| notExposeAsWebApp: 'true' | ||
| dockerfileLines: | ||
| - FROM andremoura/helper:1.0 AS helper |
There was a problem hiding this comment.
I just realized that helper image is just a temporary image to serve some files, why not inline everything here?
https://github.com/AndrMoura/posthog-caprover/blob/main/helper_files.sh
Something like this:
FROM alpine AS build
WORKDIR /
RUN curl -L https://github.com/PostHog/posthog/tarball/c25b571388a9ad05d529a14daee8f49819280496 | tar -xz --wildcards --strip-components=2 -C "./" '*/posthog/idl/*'
RUN curl -L https://github.com/PostHog/posthog/tarball/c25b571388a9ad05d529a14daee8f49819280496 | tar -xz --wildcards --strip-components=2 -C "$DOCKER_DIR" '*/docker/*'
There was a problem hiding this comment.
I over-complicated things a bit! Fixed! :)
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.
☑️ Self Check before Merge
npm ci && npm run validate_apps && npm run formatter(If failling run the prettier:npm run formatter-write)