Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PrivateBin to 1.5.1. Added persistent config volume #958

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Updated PrivateBin to 1.5.1. Added persistent config volume #958

merged 1 commit into from
Jun 29, 2023

Conversation

ivanskodje
Copy link
Contributor

@ivanskodje ivanskodje commented Jun 29, 2023

Changes

  • Updated PrivateBin to version 1.5.1 (see tags)
  • Added volume for the config folder to allow overriding PrivateBin configurations. See configuration for documentation.

By default the config folder is completely empty, so it wont affect existing or new deployments. It will, however, allow us to add our own conf.php based on their template.

Help Wanted

If there is a way to edit/add config from within CapRover without needing to SSH into the server and manually create a conf.php file, please let me know.

PrivateBin have configuration file sample that would be perfect as a can use as a placeholder, with everything that is non-default is commented out. This would be the ideal way to manage custom config. 🐈

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@githubsaturn
Copy link
Collaborator

If there is a way to edit/add config from within CapRover without needing to SSH into the server and manually create a conf.php file, please let me know.

You can look at the "filebrowser" one click app - it's pretty handy for these situations.

@githubsaturn githubsaturn merged commit d4aa50c into caprover:master Jun 29, 2023
@githubsaturn
Copy link
Collaborator

Thanks!

@ivanskodje ivanskodje deleted the PrivateBin-cfg branch June 29, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants