Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wordpress, wordpress-only): use generated default password #964

Merged
merged 1 commit into from
Jul 13, 2023
Merged

feat(wordpress, wordpress-only): use generated default password #964

merged 1 commit into from
Jul 13, 2023

Conversation

ronaldloyko
Copy link
Contributor

This pull request adds randomly generated default database passwords to the Wordpress one-click-applications.

Checks

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@githubsaturn githubsaturn merged commit f529424 into caprover:master Jul 13, 2023
@githubsaturn
Copy link
Collaborator

Thanks!

@ronaldloyko ronaldloyko deleted the default-password-for-wordpress branch July 13, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants