Skip to content

Commit

Permalink
Change delete ensembler api response from int to struct (#364)
Browse files Browse the repository at this point in the history
  • Loading branch information
deadlycoconuts authored Oct 5, 2023
1 parent 7fa5d36 commit 22d15b1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion api/turing/api/ensemblers_api.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ func (c EnsemblersController) DeleteEnsembler(
return Error(httpStatus, "failed to delete the ensembler", err.Error())
}

return Ok(ensembler.GetID())
return Ok(map[string]int{"id": int(ensembler.GetID())})
}

func (c EnsemblersController) checkActiveRouterVersion(options EnsemblersPathOptions) (int, error) {
Expand Down
4 changes: 2 additions & 2 deletions api/turing/api/ensemblers_api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ func TestEnsemblerController_DeleteEnsembler(t *testing.T) {
mlflowSvc.On("DeleteExperiment", mock.Anything, "1", true).Return(nil)
return mlflowSvc
},
expected: Ok(models.ID(2)),
expected: Ok(map[string]int{"id": 2}),
},
"success": {
vars: RequestVars{
Expand Down Expand Up @@ -962,7 +962,7 @@ func TestEnsemblerController_DeleteEnsembler(t *testing.T) {
mlflowSvc.On("DeleteExperiment", mock.Anything, "1", true).Return(nil)
return mlflowSvc
},
expected: Ok(models.ID(2)),
expected: Ok(map[string]int{"id": 2}),
},
}
for name, tt := range tests {
Expand Down

0 comments on commit 22d15b1

Please sign in to comment.