-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUG] Fix End-to-End test suite (#189)
* - debug e2e test * - debug e2e test * - debug e2e test * - debug e2e test * - debug e2e test * - extend unit test for the ExperimentRunner impl
- Loading branch information
1 parent
d12014c
commit 6d9df86
Showing
3 changed files
with
148 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
engines/experiment/examples/plugins/hardcoded/runner_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package hardcoded | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "net/http" | ||
| "testing" | ||
|
|
||
| "github.com/gojek/turing/engines/experiment/manager" | ||
| "github.com/gojek/turing/engines/experiment/pkg/request" | ||
| "github.com/gojek/turing/engines/experiment/runner" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestExperimentRunner_GetTreatmentForRequest(t *testing.T) { | ||
| experiments := []Experiment{ | ||
| { | ||
| Experiment: manager.Experiment{ | ||
| ID: "001", | ||
| Name: "exp_1", | ||
| Variants: []manager.Variant{ | ||
| { | ||
| Name: "control", | ||
| }, | ||
| { | ||
| Name: "treatment-1", | ||
| }, | ||
| }, | ||
| }, | ||
| SegmentationConfig: SegmenterConfig{ | ||
| Name: "customer_id", | ||
| SegmenterSource: request.PayloadFieldSource, | ||
| SegmenterValue: "client.id", | ||
| }, | ||
| VariantsConfig: map[string]TreatmentConfig{ | ||
| "control": { | ||
| Traffic: 0.85, | ||
| Data: json.RawMessage(`{"foo": "bar"}`), | ||
| }, | ||
| "treatment-1": { | ||
| Traffic: 0.15, | ||
| Data: json.RawMessage(`{"bar": "baz"}`), | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| suite := map[string]struct { | ||
| experiments []Experiment | ||
| header http.Header | ||
| payload json.RawMessage | ||
| expected *runner.Treatment | ||
| err string | ||
| }{ | ||
| "success | client_id:4": { | ||
| experiments: experiments, | ||
| payload: json.RawMessage(`{"client": {"id": 4}}`), | ||
| expected: &runner.Treatment{ | ||
| ExperimentName: "exp_1", | ||
| Name: "control", | ||
| Config: json.RawMessage(`{"foo": "bar"}`), | ||
| }, | ||
| }, | ||
| "success | client_id:7": { | ||
| experiments: experiments, | ||
| payload: json.RawMessage(`{"client": {"id": 7}}`), | ||
| expected: &runner.Treatment{ | ||
| ExperimentName: "exp_1", | ||
| Name: "treatment-1", | ||
| Config: json.RawMessage(`{"bar": "baz"}`), | ||
| }, | ||
| }, | ||
| "failure": { | ||
| experiments: experiments, | ||
| payload: json.RawMessage(`{}`), | ||
| err: "no experiment configured for the unit", | ||
| }, | ||
| } | ||
|
|
||
| for name, tt := range suite { | ||
| t.Run(name, func(t *testing.T) { | ||
| expRunner := ExperimentRunner{experiments: tt.experiments} | ||
|
|
||
| actual, err := expRunner.GetTreatmentForRequest(tt.header, tt.payload, runner.GetTreatmentOptions{}) | ||
| if tt.err != "" { | ||
| require.Error(t, err) | ||
| require.EqualError(t, err, tt.err) | ||
| } else { | ||
| require.NoError(t, err) | ||
| assert.Equal(t, tt.expected, actual) | ||
| } | ||
| }) | ||
| } | ||
| } |