Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to merge original request and enricher response headers #176

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

deadlycoconuts
Copy link
Contributor

This PR introduces a minor change to merge the headers of the original request sent to Turing routers with that of the response returned from an enricher.

This in effect parses the enricher response headers for downstream traffic rules and experiment input, but does not parse them for ensembling.

Modifications

  • engines/router/missionctl/handlers/http_handler.go - Addition of a few lines of code to merge the headers of the original request and enricher response

@deadlycoconuts deadlycoconuts requested a review from a team March 8, 2022 08:18
Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I think it would be useful to also log the enricher's response header in the outcome logs. This will require a change to the proto. We can tackle this as a separate item.

engines/router/missionctl/handlers/http_handler.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants