Remove system kafka config from db and api #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonlnj
changed the title
krithika369
changed the title
leonlnj
added a commit
that referenced
this pull request
Mar 11, 2022
* update kafka config to not be saved in db * update kafka config to not be saved in db - sort imports * use plural for routerDefaults var * use plural for routerDefaults var Co-authored-by: leonlnj <[email protected]> (cherry picked from commit e6a6dfa)
leonlnj
added a commit
that referenced
this pull request
Mar 11, 2022
* update kafka config to not be saved in db * update kafka config to not be saved in db - sort imports * use plural for routerDefaults var * use plural for routerDefaults var Co-authored-by: leonlnj <[email protected]> (cherry picked from commit e6a6dfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This MR seeks to patch the kafka configuration that was created previously.
Modification
MaxMessageBytesandCompressionTypefrom/api/*as its not required to persist in db nor return in api response. From the api server perspective it only needs to create the env var inapi/turing/cluster/servicebuilder/router.go-buildRouterEnvswhich will be picked up by the router.routerDefaultinstead of individual default as arguments