-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyfunc bugs for release #188
Fix pyfunc bugs for release #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments. LGTM, pending the discussion about the e2e test case. Thank you!
fff0052
to
353954a
Compare
@romanwozniak https://github.com/gojek/turing/runs/5715592714?check_suite_focus=true#step:18:78 🥲 I'll go look at it again and see what went wrong. |
I have only two assumptions:
You probably can merge this MR and keep the fix to the E2E test out of scope for now |
@deadlycoconuts actually, it's neither nor. I can reproduce the issue by running the unit test ( which I added recently) multiple times. However, the hashing is consistent. It could be related to the floating-point precision or something similar. Let me try to figure it out |
Thanks a lot for your help for the time being @romanwozniak ! |
TIL: |
@deadlycoconuts It's fixed now. Sorry, for hijacking your PR. The diff is here: |
Haha no worries, thanks a lot for digging into and solving the mystery of this really elusive bug! 😂 |
Okay I'll be merging this if there aren't anything outstanding left! Thanks a lot everyone for your input! 🚀 |
Context
This PR aims to include a couple of minor bug fixes and refactoring before the upcoming minor release of Turing:
features
keyword argument of the abstractensemble
method inEnsemblerBase
of the SDK toinput
for less ambiguity when implementing Pyfunc ensemblerslist
of route responses in real-time ensembler requests to adict
of route responses indexed by route names in the SDKPyFunc
interface, so as to improve usability and consistency of thepredictions
keyword argument of the aforementionedensemble
method3.7.*
. This is to align Turing with Merlin's support for Python of that particular minor version.