fix(image-builder):Refactor ensembler image naming convention #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
deadlycoconuts
added a commit
to caraml-dev/merlin
that referenced
this pull request
Feb 15, 2024
# Description
This fix/enhancement revises the image naming convention for both model
and batch job images built by the image builder to make them consistent
with the convention used in Turing:
### Before
```
{dockerRegistry}/{projectName}-{modelName}:{versionID}
```
### After
```
{dockerRegistry}/{projectName}/pyfunc-models/{modelName}:{versionID}
```
or
```
{dockerRegistry}/{projectName}/batch-jobs/{modelName}:{versionID}
```
**_This PR contains changes similar to what is implemented for Turing in
caraml-dev/turing#368
# Modifications
- `api/pkg/imagebuilder/model_service_imagebuilder.go` - Change in
template string for the pyfunc model service image name
- `api/pkg/imagebuilder/prediction_job_imagebuilder.go` - Change in
template string for the batch job image name
# Tests
- [x] Deploying PyFunc models
# Checklist
- [x] Added PR label
- [x] Added unit test, integration, and/or e2e tests
- [x] Tested locally
- [ ] Updated documentation
- [ ] Update Swagger spec if the PR introduce API changes
- [ ] Regenerated Golang and Python client if the PR introduces API
changes
# Release Notes
```release-note
NONE
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This fix/enhancement revises the image naming convention for both ensembler service and ensembler job images built by the image builder:
Before
or
After
or
By removing the
runIDfrom the image name, we now allow all images built for the same ensembler to be stored within the same image repository as opposed to storing them in separate repositories. Furthermore, since all built images of the same ensembler will now be stored in the same repository, we now tag them with their specificrunID-s in order to distinguish between different versions of the same ensembler.This PR contains changes similar to what is implemented for Merlin in caraml-dev/merlin#526.
Modifications
api/turing/imagebuilder/ensembler.go- Change in template string for the ensembler image nameapi/turing/imagebuilder/imagebuilder.go- Change of image tag fromensemblerIDtorunID