fix(ui): Add helper function to cast string to array before yup validation #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it against a given schema
bthari
reviewed
Aug 14, 2024
ui/src/settings/segmenters/components/form/validation/schema.js
Outdated
Show resolved
Hide resolved
|
Thanks for the quick review! I'll merge this soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It seems like after updating yup/elastic UI packages, array values in the
EuiTextAreaare expressed as a JSON literal, e.g."[\"new\"]"and these values no longer get automatically parsed into a JSON array at the yup validation stage. As a result, all the.array()validations that were performed no longer work and fail (because they report a string being present instead). The screenshot attached shows how the validation reports an error even though nothing is wrong with the input in the text fields.An additional step is thus introduced to manually parse the literal input into a JSON array (failing the validation check if it isn't), and to validate the parsed array with respect to the original schema.
Which issue(s) this PR fixes:
Fixes #