Add isreadby isread methods to message model #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryKitten
reviewed
Dec 7, 2022
tests/Unit/ConversationTest.php
Outdated
| } | ||
| } | ||
|
|
||
| public function testUnreadBy() |
There was a problem hiding this comment.
Suggested change
| public function testUnreadBy() | |
| public function testUnreadBy(): void |
BinaryKitten
reviewed
Dec 7, 2022
tests/Unit/MessageTest.php
Outdated
Comment on lines
13
to
19
| private string $senderId; | ||
|
|
||
| private array $messages; | ||
|
|
||
| private Message $message1; | ||
|
|
||
| private Message $message2; |
There was a problem hiding this comment.
extra spacing is not really required.. lets trim it down.
Suggested change
| private string $senderId; | |
| private array $messages; | |
| private Message $message1; | |
| private Message $message2; | |
| private string $senderId; | |
| private array $messages; | |
| private Message $message1; | |
| private Message $message2; |
There was a problem hiding this comment.
This is how it is formatted in the other files, that's why I added it here. But completely agree it looks better without spaces.
BinaryKitten
suggested changes
Dec 7, 2022
BinaryKitten
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some helpful methods to the Messages and Conversation models.
Message:
Conversation:
Updated the testing to have Unit tests along with the Feature tests.