Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Provide wrapper components for all Carbon react components #355

Closed
3 tasks done
tay1orjones opened this issue Jun 25, 2019 · 4 comments
Closed
3 tasks done

[v2] Provide wrapper components for all Carbon react components #355

tay1orjones opened this issue Jun 25, 2019 · 4 comments

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jun 25, 2019

Wrap/re-export Carbon components from our package so consumers can import from one place. Implementation from proposal in #268

  • Re-export components we don't currently have in our package
  • Evaluate publishing sass as well (so consumers can install component styles from our package, vs carbon)
    • export single entrypoint like Carbon, we can override any components via extending their mixins
  • Update storybook with the stories of newly exported components
    • Segment storybook nav into sections: Stock, Extended, Custom
@tay1orjones tay1orjones self-assigned this Jun 25, 2019
@tay1orjones tay1orjones changed the title [v2] Add Carbon components wrappers [v2] Provide wrapper components for all Carbon react components Jun 25, 2019
@tay1orjones tay1orjones mentioned this issue Jun 25, 2019
14 tasks
@tay1orjones
Copy link
Member Author

tay1orjones commented Jul 16, 2019

Things remaining after the above PR is merged

  • fix naming collisions in js exports, make sure we're exporting every component that carbon-components-react does, plus ours. to be satisfied in [v2] Align Name and prop model between Carbon and our components #369
  • import all the stories for the stock carbon components
  • figure out how to provide individual .scss files for consumers, in addition to the compiled .css file. This includes not only the component sass files, but we should export the globals (colors, layout, etc) like the carbon package does. The Security addons is doing this as an example.

From the initial issue description, we still need to look into how to segment the storybook left panel into sections, despite not being able to 'control' the name of the Carbon stories we're importing.

@tay1orjones
Copy link
Member Author

We've segmented the storybook into sections and used css to change 'others' to 'carbon components'

The original scope of this issue is satisfied by the above PRs. Closing.

@tay1orjones
Copy link
Member Author

🎉 This issue has been resolved in version 2.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tay1orjones
Copy link
Member Author

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant