Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stories for Stock Carbon Components #407

Merged
merged 12 commits into from
Jul 26, 2019
Merged

Add Stories for Stock Carbon Components #407

merged 12 commits into from
Jul 26, 2019

Conversation

tay1orjones
Copy link
Member

Summary

  • Add most all of the stories to our storybook for the carbon components we're just re-exporting without modifications.
  • Separate stories into a Watson IoT section, and storybook's default of others (which for now contains all the carbon "stock" stories)
  • Add a dep required by the carbon stories
  • Comment out stories that require the readme files present in their repo but not in the distributed package (we need to figure out a solution for these stories - UIShell and MultiSelect)
  • Rename a11y addon - it was showing a console warning

Related Issues

Acceptance Test (how to verify the PR)

  • view the deploy test storybook, should be many more stories, verify they work.
  • double check we have all the stories present in the carbon storybook @ react.carbondesignsystem.com

@netlify
Copy link

netlify bot commented Jul 22, 2019 •
edited
Loading

Deploy preview for carbon-addons-iot-react ready!

Built with commit 752ce31

https://deploy-preview-407--carbon-addons-iot-react.netlify.com

davidicus
davidicus requested changes Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@davidicus davidicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some visual defects from our storybook container being full width. Which we just added to fix our visual defects.

image

This one is slightly under teh storybook show more button

image

I am not sure if FormLabel with tooltip is supposed to actually work in the story but no tool tip is popping. I think this is a carbon bug

All in all it looks good. just a few visual defects.

@tay1orjones
Copy link
Member Author

@davidicus I just pushed a fix for the overlap issue - just increased the padding on the story container. It actually makes all the stories look better imo, bit more breathing room.

The FormLabel with tooltip doesn't work in Carbon's story either: http://react.carbondesignsystem.com/?path=/story/formlabel--with-tooltip

@tay1orjones tay1orjones merged commit f16f56f into beta Jul 26, 2019
@tay1orjones tay1orjones deleted the carbon-component-stories branch July 26, 2019 21:03
@tay1orjones
Copy link
Member Author

🎉 This PR is included in version 2.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tay1orjones
Copy link
Member Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidicus davidicus davidicus approved these changes

@bryancboyd bryancboyd Awaiting requested review from bryancboyd bryancboyd is a code owner

@cgirani cgirani Awaiting requested review from cgirani cgirani is a code owner

@filipecorrea filipecorrea Awaiting requested review from filipecorrea

@leetosc leetosc Awaiting requested review from leetosc leetosc is a code owner

@scottdickerson scottdickerson Awaiting requested review from scottdickerson

@stuckless stuckless Awaiting requested review from stuckless

@tomklapiscak tomklapiscak Awaiting requested review from tomklapiscak

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tay1orjones @davidicus