Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): increase coverage on ValueRenderer #2695

Merged
merged 8 commits into from
Aug 24, 2021

Conversation

kevinsperrine
Copy link
Collaborator

@kevinsperrine kevinsperrine commented Aug 19, 2021

Closes #2550

Summary

  • more tests

Change List (commits, features, bugs, etc)

  • add new ValueRenderer.test.jsx to target specific missing portions

Acceptance Test (how to verify the PR)

  • coverage now 90%+

Regression Test (how to make sure this PR doesn't break old functionality)

  • n/a

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for ai-apps-pal-angular ready!

🔨 Explore the source changes: c209e34

🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/61256a164415c60008ac7b19

😎 Browse the preview: https://deploy-preview-2695--ai-apps-pal-angular.netlify.app

@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for carbon-addons-iot-react ready!

🔨 Explore the source changes: c209e34

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/61256a16540e650007b74eee

😎 Browse the preview: https://deploy-preview-2695--carbon-addons-iot-react.netlify.app/

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 24, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

@kodiakhq kodiakhq bot merged commit e7552eb into next Aug 24, 2021
@kodiakhq kodiakhq bot deleted the 2550-value-renderer-coverage branch August 24, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ValueRenderer] improve unit test coverage
3 participants