Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suiteheader): close menu on click outside in safari #3772

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

erzhan-temir-mamyrov
Copy link
Collaborator

@erzhan-temir-mamyrov erzhan-temir-mamyrov commented Apr 18, 2023

Part of #3763

Summary

  • Close header menus on other menu click or click outside

Change List (commits, features, bugs, etc)

  • Add listeners to menus in header to close on click outside
  • Add tests

Acceptance Test (how to verify the PR)

  • On Safari
  • Go to this story
  • Open some header menu
  • Click outside of the menu
  • Verify that menu has been closed
  • Note: menu is not closing if click event is inside dropdown (unless it's a link or other action)

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 5936ae8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/643e6e7fb2575400083a8010
😎 Deploy Preview https://deploy-preview-3772--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@jessieyan jessieyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@kodiakhq kodiakhq bot merged commit c0581ca into next Apr 19, 2023
@kodiakhq kodiakhq bot deleted the fix-3763-safari branch April 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants