Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web-components]: cds-side-nav-menu > menu-body has a max-height #10936

Closed
2 tasks done
korgan00 opened this issue Sep 14, 2023 · 3 comments
Closed
2 tasks done

[Web-components]: cds-side-nav-menu > menu-body has a max-height #10936

korgan00 opened this issue Sep 14, 2023 · 3 comments
Assignees
@kennylam
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@korgan00
Copy link
Contributor

Description

The menu-body part in the cds-side-nav-menu has a max-height: 93.75rem and we are having an issue with that because it is hiding some elements. We solved it with css correction, but I don't know if you are aware of it.

It seems quite arbitrary. Is there any specific reason?

I know it has a max-height: 0 on not-expanded state. It can be solved with a max-height: none instead of 93.75rem.

Component(s) impacted

UIShell / cds-side-nav-menu

Browser

No response

Carbon for IBM.com version

v2.0.1

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

IBM Quantum Learning

Package

@carbon/web-components

CodeSandbox example

https://stackblitz.com/edit/github-kqdr6r?file=index.html

Steps to reproduce the issue (if applicable)

Create a sidenav and fill it with a lot of items.

In the case of the stackblitz that I created, elements over 46 are hidden, there are 59.

Release date (if applicable)

No response

Code of Conduct
@korgan00 korgan00 added bug Something isn't working dev Needs some dev work labels Sep 14, 2023
@kennylam kennylam self-assigned this Sep 18, 2023
@abdonrd
Copy link
Contributor

abdonrd commented Jan 5, 2024

@kennylam I see you self-assigned here. Any ETA to fix it? Thanks! 🙏

@abdonrd
Copy link
Contributor

abdonrd commented Feb 5, 2024

Any news here? Thanks!

kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Feb 22, 2024
@kennylam
fix(side-nav): update max-block-size; closes carbon-design-system#10936
0d659f7
@kennylam kennylam mentioned this issue Feb 22, 2024
Merged
@kennylam
Copy link
Member

@abdonrd @korgan00 This will be included in v2.4.0, which will release Feb 26!

kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 12, 2024
@kennylam @ariellalgilmore
fix(side-nav): update max-block-size; closes carbon-design-system#10936…
eae2a25 
… (carbon-design-system#11571)

Co-authored-by: Ariella Gilmore <[email protected]>
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@kennylam @ariellalgilmore
fix(side-nav): update max-block-size; closes carbon-design-system#10936…
ae55085 
… (carbon-design-system#11571)

Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennylam @abdonrd @korgan00