Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WC modal gradient updates #11500

Closed
ariellalgilmore opened this issue Feb 7, 2024 · 0 comments · Fixed by #11533
Closed

WC modal gradient updates #11500

ariellalgilmore opened this issue Feb 7, 2024 · 0 comments · Fixed by #11533
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components
Milestone
Phase 2 - C4AI

Comments

@ariellalgilmore
Copy link
Member

follow up to react #15709
@ariellalgilmore ariellalgilmore added this to the Phase 2 - C4AI milestone Feb 7, 2024
@ariellalgilmore ariellalgilmore added package: carbon web components area: AI Used to filter issues in the Carbon for AI project. labels Feb 7, 2024
@ariellalgilmore ariellalgilmore mentioned this issue Feb 13, 2024
Merged
@kodiakhq kodiakhq bot closed this as completed in #11533 Feb 16, 2024
kodiakhq bot pushed a commit that referenced this issue Feb 16, 2024
@ariellalgilmore
feat(modal): ai updates (#11533)
d60f94a 
### Related Ticket(s)

Closes #11500 

### Description

updates modal to latest AI gradient updates
### Changelog

**New**

- modal now checks if footer slotted for styles

**Changed**

- modal-footer reverted code back to only checking if there are three buttons
- updated styles

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@ariellalgilmore
feat(modal): ai updates (carbon-design-system#11533)
c478781 
### Related Ticket(s)

Closes carbon-design-system#11500 

### Description

updates modal to latest AI gradient updates
### Changelog

**New**

- modal now checks if footer slotted for styles

**Changed**

- modal-footer reverted code back to only checking if there are three buttons
- updated styles

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components
Projects
Carbon for AI
Status: ✅ Done
Carbon for IBM.com
Archived in project
Milestone
Phase 2 - C4AI
Development

Successfully merging a pull request may close this issue.

feat(modal): ai updates ariellalgilmore/carbon-for-ibm-dotcom
1 participant
@ariellalgilmore