Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content blocks and groups] - React Storybook - #5863

Closed
DragosRistici opened this issue Apr 22, 2021 · 0 comments
Closed

[Content blocks and groups] - React Storybook - #5863

DragosRistici opened this issue Apr 22, 2021 · 0 comments
Assignees
@NSDrowned
Labels
bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package package: styles Work necessary for the Carbon for IBM.com styles package severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 21-09

Comments

@DragosRistici
Copy link

The ordered list in all the examples in React Storybook (every block and group page that has that piece of content) has an overhang in the content from this css:
Screenshot 2021-04-22 at 14 18 30

What it looks like
Screenshot 2021-04-22 at 14 13 45

The issue is minor, but it is present on multiple pages of the React Storybook.

The issue was opened separately as per @IgnacioBecerra request.
@DragosRistici DragosRistici added bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package storybook labels Apr 22, 2021
@RobertaJHahn RobertaJHahn added the severity 3 Affects minor functionality, has a workaround label Apr 22, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-09 milestone Apr 22, 2021
@RobertaJHahn RobertaJHahn added package: styles Work necessary for the Carbon for IBM.com styles package Airtable Done and removed storybook labels Apr 22, 2021
@NSDrowned NSDrowned self-assigned this Apr 27, 2021
@NSDrowned NSDrowned mentioned this issue Apr 27, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Apr 28, 2021
@NSDrowned
fix: list margin fix (#5919)
4f191a9 
### Related Ticket(s)

#5863

### Description

Carbon list had a bug in which ordered list items required an extra left margin to align correctly. This bug has fixed now and the extra margin is no longer needed.

**Removed**

- Removed extra margin from carbon expressive theme
- Removed `_list.scss` file from theme since it's no longer needed

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NSDrowned NSDrowned

Labels
bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package package: styles Work necessary for the Carbon for IBM.com styles package severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-09
Development

No branches or pull requests
9 participants
@jeffchew @NSDrowned @shixiedesign @ariellalgilmore @ljcarot @IgnacioBecerra @JennySanchez @DragosRistici @RobertaJHahn