Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio-button): add missing slot optioin #11307

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix(radio-button): add missing slot optioin #11307

merged 3 commits into from
Jan 4, 2024

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Closes #11288

Description

fixes slot for radio-button

Changelog

New

  • {{new thing}}

Changed

  • accidentally got removed .... but adding <slot> around ${labelText}

Removed

  • {{removed thing}}

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner January 3, 2024 18:43
@ariellalgilmore ariellalgilmore requested review from kennylam and emyarod and removed request for a team January 3, 2024 18:43
emyarod
emyarod approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Jan 3, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11307/index.html

Built with commit: 776a284855ad5bc58c166c1c47f72c57b627d2d9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11307/index.html

Built with commit: 776a284855ad5bc58c166c1c47f72c57b627d2d9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11307/index.html

Built with commit: 776a284855ad5bc58c166c1c47f72c57b627d2d9

@kodiakhq kodiakhq bot merged commit 95e9eb5 into carbon-design-system:main Jan 4, 2024
11 of 20 checks passed
@abdonrd
Copy link
Contributor

abdonrd commented Jan 17, 2024 •
edited
Loading

@ariellalgilmore I just see you release @carbon/[email protected]

Shouldn't this have this PR? It seems that it has not been part:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/commits/%40carbon/web-components%402.1.2/

Thanks!

@ariellalgilmore
Copy link
Member Author

Since there is a workaround, this PR will go into the next release. We start code freeze on the next release this Friday

@ariellalgilmore ariellalgilmore deleted the fix/radio-button-slot branch January 17, 2024 20:23
@abdonrd
Copy link
Contributor

abdonrd commented Jan 17, 2024

For our case there is no workaround: #11288 (comment)

But ok, we can wait until next release.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@ariellalgilmore @kennylam
fix(radio-button): add missing slot optioin (carbon-design-system#11307)
b1d79ab 
### Related Ticket(s)

Closes carbon-design-system#11288 
### Description

fixes slot for radio-button
### Changelog

**New**

- {{new thing}}

**Changed**

- accidentally got removed .... but adding `<slot>` around `${labelText}`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ariellalgilmore
fix(radio-button): add missing slot optioin (carbon-design-system#11307)
2315892 
### Related Ticket(s)

Closes carbon-design-system#11288 
### Description

fixes slot for radio-button
### Changelog

**New**

- {{new thing}}

**Changed**

- accidentally got removed .... but adding `<slot>` around `${labelText}`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The slots no longer work on radio buttons
5 participants
@ariellalgilmore @ibmdotcom-bot @abdonrd @emyarod @kennylam