Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: side panel story slug alignment #11594

Merged
merged 6 commits into from
Feb 29, 2024
Merged

fix: side panel story slug alignment #11594

merged 6 commits into from
Feb 29, 2024

Conversation

lee-chase
Copy link
Member

Related Ticket(s)

Description

Changes to the cds-slug required the addition of an alignment property to the slug in the SidePanel story.

Changelog

Changed

  • packages/carbon-web-components/src/components/side-panel/side-panel-story.ts

@lee-chase lee-chase requested a review from a team as a code owner February 28, 2024 10:00
@lee-chase lee-chase requested review from kennylam and annawen1 and removed request for a team February 28, 2024 10:00
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 28, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11594/index.html

Built with commit: c428710db5381abfd7dd90ec464364e3db4b0ae5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 28, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11594/index.html

Built with commit: c428710db5381abfd7dd90ec464364e3db4b0ae5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 28, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11594/index.html

Built with commit: c428710db5381abfd7dd90ec464364e3db4b0ae5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 28, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11594/index.html

Built with commit: c428710db5381abfd7dd90ec464364e3db4b0ae5

ariellalgilmore
ariellalgilmore approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Feb 29, 2024
@ariellalgilmore ariellalgilmore merged commit b0ee3b7 into carbon-design-system:main Feb 29, 2024
5 of 9 checks passed
@annawen1
Copy link
Member

Hey there! This issue/pull request was referenced in recently released v2.5.0.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@lee-chase @ariellalgilmore @kodiakhq
fix: side panel story slug alignment (carbon-design-system#11594)
63f3362 
* fix: side panel story slug

* fix: remove slug slot in story

* fix: remove slug-container classname

---------

Co-authored-by: Ariella Gilmore <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lee-chase @ibmdotcom-bot @annawen1 @ariellalgilmore