Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dotcom-components): add shadowparts #11812

Merged
merged 72 commits into from
Aug 13, 2024
Merged

feat(dotcom-components): add shadowparts #11812

merged 72 commits into from
Aug 13, 2024

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented May 22, 2024 •
edited by andy-blum
Loading

Related Ticket(s)

Closes #11673

Description

This PR updates all component-internal in dotcom-web-components markup to include part attributes in the shadow roots allowing global stylesheets to override internal styles.

Changelog

Changed

  • Add CSS Shadowparts to @carbon/ibmdotcom-web-components components

andy-blum and others added 5 commits May 21, 2024 15:33
@andy-blum
feat(content-group-cards): add shadowparts (#11795)
485b633 
* feat(content-group-cards): add shadowparts

* feat(content-group-cards): update unit test snapshots
@andy-blum
Merge branch 'main' into v2-shadow-parts
6e74cfa
@bruno-amorim
feat(background-media): add shadow parts to bg-media (#11798)
013f7a4 
* feat(background-media): add shadow parts to bg-media

* feat(background-shadow): changing part names to be more consistent

* feat(background-shadow): updating Snapshots
@bruno-amorim
feat(back-to-top): add shadow part (#11796)
f2af215 
* feat(back-to-top-btn): adding shadow part so that the component can be styled from outside shadow

* feat(back-to-top): using a better name for the part attribute
@marcelojcs
feat(callout-quote): add shadow parts (#11800)
825a8a3 
* feat(callout-quote): add shadoe part

* feat(callout-quote): updated snapshots

* feat(callout-quote): add shadow parts to all components

* feat(callout-quote): update snapshots

* feat(callout-quote): simplify part names

* feat(callout-quote): update snapshots
@jkaeser jkaeser added owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants DO NOT MERGE shadow parts labels May 22, 2024
@jkaeser jkaeser requested a review from a team as a code owner May 22, 2024 13:15
@jkaeser jkaeser mentioned this pull request May 22, 2024
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11812/index.html

Built with commit: 6ebde5285ae949826072aadade0cdf7150cbc03d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11812/index.html

Built with commit: 6ebde5285ae949826072aadade0cdf7150cbc03d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11812/index.html

Built with commit: 6ebde5285ae949826072aadade0cdf7150cbc03d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 22, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11812/index.html

Built with commit: 6ebde5285ae949826072aadade0cdf7150cbc03d

m4olivei and others added 5 commits May 22, 2024 13:48
@m4olivei
feat(carousel): add shadowparts (#11807)
250ced4 
* feat(carousel): add shadowparts

* feat(carousel): update snapshot
@m4olivei
feat(content-block): add shadowparts (#11809)
2f1f891 
* feat(content-block): add shadowparts

* feat(content-block): update snapshot
@marcelojcs
feat(card): add shadow parts (#11802)
134c038 
* feat(card): adning shadow parts

* feat(card): refreshed the snapshots

* feat(card): ran yarn format

* feat(card): rename disabled link part
@Valentin-Sorin-Nicolae
feat(content-item): add shadow parts (#11814)
1289b9e
@Valentin-Sorin-Nicolae
feat(content-section): add shadow parts (#11816)
1761ce3
bruno-amorim and others added 2 commits July 24, 2024 15:41
@bruno-amorim
feat(text-input): adding shadow parts (#11938)
ce9e8db 
* feat(text-input): adding shadow parts

* feat(text-input): improving some part nomenclatures
@andy-blum
Merge branch 'main' into feat/v2-shadow-parts
2285659
@andy-blum
Copy link
Member

andy-blum commented Jul 29, 2024 •
edited
Loading

CWC is in the process of moving to the carbon monorepo. To avoid blocking this effort further:

  1. I've created a new branch feat/cds-shadow-parts from this branch
  2. I will revert the commits for all cwc components in this PR
  3. I will open this PR for full review

@andy-blum andy-blum changed the title feat(all-components): add shadowparts feat(dotcom-components): add shadowparts Jul 29, 2024
@andy-blum andy-blum requested review from kennylam, m4olivei, andy-blum and a team and removed request for kennylam and m4olivei July 29, 2024 19:04
@andy-blum andy-blum added package: web components Work necessary for the IBM.com Library web components package and removed DO NOT MERGE labels Jul 29, 2024
m4olivei
m4olivei approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice to see this finish. Just one point of clarification, nothing blocking.

packages/carbon-web-components/tests/snapshots/cds-combo-box.md Show resolved Hide resolved
@m4olivei m4olivei added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Jul 31, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 31, 2024 •
edited
Loading

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11812/index.html

Built with commit: 6ebde5285ae949826072aadade0cdf7150cbc03d

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Aug 13, 2024
@kodiakhq kodiakhq bot merged commit b8983f2 into main Aug 13, 2024
19 of 33 checks passed
@kodiakhq kodiakhq bot deleted the feat/v2-shadow-parts branch August 13, 2024 17:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hey there! This issue/pull request was referenced in recently released v2.12.0.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hey there! This issue/pull request was referenced in recently released v2.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@m4olivei m4olivei m4olivei approved these changes

@andy-blum andy-blum Awaiting requested review from andy-blum

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra

@annawen1 annawen1 Awaiting requested review from annawen1

Assignees
No one assigned
Labels
owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge shadow parts test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add part attributes to elements in the shadow DOM
8 participants
@jkaeser @ibmdotcom-bot @m4olivei @andy-blum @kennylam @bruno-amorim @marcelojcs @Valentin-Sorin-Nicolae