Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): remove all use of carbon--mini-units #11964

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix(styles): remove all use of carbon--mini-units #11964

merged 2 commits into from
Aug 7, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Aug 5, 2024

Related Ticket(s)

Closes #11958

Description

Replaces carbon--mini-units, which is no longer part of Carbon v11, with the equivalent $spacing-* token, or to-rem call for the intended pixel size.

Changelog

Changed

  • Replaces all carbon--mini-units calls with v11 equivalent.

@m4olivei m4olivei added bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing labels Aug 5, 2024
@m4olivei m4olivei requested a review from andy-blum August 5, 2024 13:28
@m4olivei m4olivei requested a review from a team as a code owner August 5, 2024 13:28
@m4olivei m4olivei requested review from sangeethababu9223 and removed request for a team August 5, 2024 13:28
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 6, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11964/index.html

Built with commit: ba63874dcc9561a1b8faf3c8bebdeb91d304f887

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 6, 2024 •
edited
Loading

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11964/index.html

Built with commit: ba63874dcc9561a1b8faf3c8bebdeb91d304f887

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 6, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11964/index.html

Built with commit: ba63874dcc9561a1b8faf3c8bebdeb91d304f887

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 6, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11964/index.html

Built with commit: ba63874dcc9561a1b8faf3c8bebdeb91d304f887

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 6, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11964/index.html

Built with commit: ba63874dcc9561a1b8faf3c8bebdeb91d304f887

kennylam
kennylam approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @m4olivei!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Aug 7, 2024
@kodiakhq kodiakhq bot merged commit f6b3398 into carbon-design-system:main Aug 7, 2024
14 of 21 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hey there! This issue/pull request was referenced in recently released v2.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@andy-blum andy-blum Awaiting requested review from andy-blum

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[styles]: Undefined carbon--mini-units Sass function is left in compiled CSS in some bundler configurations
4 participants
@m4olivei @ibmdotcom-bot @kennylam @andy-blum