Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-cta): remove style overrides covered elsewhere #11966

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix(button-cta): remove style overrides covered elsewhere #11966

merged 1 commit into from
Aug 7, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Aug 5, 2024

Related Ticket(s)

Closes #11959

Description

Fixes an icon alignment issue in the <c4d-button-cta> component by removing style overrides that interfered with, or were already covered by extending c4d-button.

Changelog

Changed

  • Fix button-cta styles to correct icon alignment

@m4olivei m4olivei added bug Something isn't working severity 3 Affects minor functionality, has a workaround dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels Aug 5, 2024
@m4olivei m4olivei requested a review from andy-blum August 5, 2024 17:44
@m4olivei m4olivei requested a review from a team as a code owner August 5, 2024 17:44
@m4olivei m4olivei requested review from annawen1 and removed request for a team August 5, 2024 17:44
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11966/index.html

Built with commit: 4a3b4756751eb40ec4dd44a9ec2a60766235e6c7

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11966/index.html

Built with commit: 4a3b4756751eb40ec4dd44a9ec2a60766235e6c7

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11966/index.html

Built with commit: 4a3b4756751eb40ec4dd44a9ec2a60766235e6c7

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11966/index.html

Built with commit: 4a3b4756751eb40ec4dd44a9ec2a60766235e6c7

kennylam
kennylam approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added Ready to merge Label for the pull requests that are ready to merge and removed bug Something isn't working severity 3 Affects minor functionality, has a workaround labels Aug 7, 2024
@kodiakhq kodiakhq bot merged commit 30afc55 into carbon-design-system:main Aug 7, 2024
13 of 21 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hey there! This issue/pull request was referenced in recently released v2.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@andy-blum andy-blum Awaiting requested review from andy-blum

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[c4d-button-cta]: CTA icon is out of alignment
3 participants
@m4olivei @ibmdotcom-bot @kennylam