Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dotcomshell): fix storybook grid layout #5921

Merged
merged 3 commits into from
May 7, 2021
Merged

chore(dotcomshell): fix storybook grid layout #5921

merged 3 commits into from
May 7, 2021

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Apr 28, 2021 •
edited
Loading

Description

Fixes LeadspaceBlock grid alignment in DotcomShell Storybook story.

Here LeadspaceBlock (top screenshot) should align with the bottom.

image

Changelog

Removed

  • Layout from LeadspaceBlock

@kennylam kennylam added the package: react Work necessary for the Carbon for IBM.com react components package label Apr 28, 2021
@kennylam kennylam changed the title chore(story): fix dotcomshell grid layout chore(dotcomshell): fix storybook grid layout Apr 28, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 28, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5921/index.html

Built with commit: f6f2013d6738a2b6fb22c0526dab3032caee0310

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 28, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5921/index.html

Built with commit: f6f2013d6738a2b6fb22c0526dab3032caee0310

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 28, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5921/index.html

Built with commit: f6f2013d6738a2b6fb22c0526dab3032caee0310

IgnacioBecerra
IgnacioBecerra approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small thing that probably doesn't fall into this PR's scope, but I noticed that Logo Grid doesn't seem to be aligning properly to the story's grid. The WC version seems to be fine though.

Screen Shot 2021-05-05 at 12 36 45 PM

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label May 6, 2021
@kodiakhq kodiakhq bot merged commit e48f3ae into carbon-design-system:master May 7, 2021
@raphaelamadeu-zz raphaelamadeu-zz mentioned this pull request May 7, 2021
Closed
@kennylam kennylam deleted the chore/dotcom-shell-story-grid branch June 1, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@DragosRistici DragosRistici Awaiting requested review from DragosRistici

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @ibmdotcom-bot @IgnacioBecerra @jeffchew