Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade marked to 1.2.9 #7935

Merged
merged 5 commits into from
Jan 7, 2022
Merged

chore(deps): upgrade marked to 1.2.9 #7935

merged 5 commits into from
Jan 7, 2022

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Jan 5, 2022 •
edited
Loading

Related Ticket(s)

#7931

Description

This upgrades the marked packaged to v1.2.9.

Changelog

New

  • marked upgraded to v1.2.9
  • add smartypants option to marked, allowing replacement of normal quotes, dashes, etc. to their 'smart' versions

Changed

  • update React and web components Storybook markdown to fix indentation. As of >=1.2.3, lists were updated to match the CommonMark spec where sub-item lists must be indented to the column of at least the first non-whitespace character (see example), e.g.:

    1. list 1
   - list item a
     - list item a.a

@kennylam kennylam requested a review from a team as a code owner January 5, 2022 20:24
@kennylam kennylam added package: react Work necessary for the Carbon for IBM.com react components package package: utilities Work necessary for the Carbon for IBM.com utilities package package: web components Work necessary for the IBM.com Library web components package labels Jan 5, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@jeffchew
Copy link
Member

jeffchew commented Jan 5, 2022

@kennylam thank you for jumping on this! Are the diffs in Percy intentional? I saw that you also updated the example content too.

@kennylam
Copy link
Member Author

kennylam commented Jan 5, 2022

Are the diffs in Percy intentional?

@jeffchew Yep! The diffs are all the changes from normal to smart quotes, now that the smartypants option has been enabled.

@jeffchew
Copy link
Member

jeffchew commented Jan 6, 2022

@kennylam looking at one of the downstream diffs, looks like the card section carousel got affected, wondering if this would have caused this change somehow?

image

@kennylam
Copy link
Member Author

kennylam commented Jan 6, 2022

wondering if this would have caused this change somehow?

No, nothing from this PR would make those layout changes. Perhaps something related to #7871?

@jeffchew
Copy link
Member

jeffchew commented Jan 6, 2022

wondering if this would have caused this change somehow?

No, nothing from this PR would make those layout changes. Perhaps something related to #7871?

Yeah possibly, I was in the middle of reviewing another PR and noticed the same thing happening. Going to approve this one!

jeffchew
jeffchew approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kennylam !

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 6, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 6, 2022 •
edited
Loading

Deploy preview created for package Utilities:
https://ibmdotcom-utilities.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7935/index.html

Built with commit: 738437a89b1819f4ed9b261813105cc88f7384d4

@jeffchew jeffchew removed the Ready to merge Label for the pull requests that are ready to merge label Jan 6, 2022
@jeffchew
Copy link
Member

jeffchew commented Jan 6, 2022

@kennylam a request was made by @oliviaflory , can you take a look?

@kennylam
Copy link
Member Author

kennylam commented Jan 7, 2022

@oliviaflory Good catch! Should be fixed now.

oliviaflory
oliviaflory approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kennylam !

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 7, 2022
@kodiakhq kodiakhq bot merged commit 0753002 into carbon-design-system:main Jan 7, 2022
@jeffchew jeffchew mentioned this pull request Jan 10, 2022
Closed
@kennylam kennylam deleted the deps/upgrade-marked branch January 25, 2022 17:49
@emyarod emyarod mentioned this pull request Jan 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviaflory oliviaflory oliviaflory approved these changes

@jeffchew jeffchew jeffchew approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package package: utilities Work necessary for the Carbon for IBM.com utilities package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @ibmdotcom-bot @jeffchew @oliviaflory