fix: race condition in DefinitionTooltip (#17622)

`onClick` -> `onMouseDown` so the action happens before `onFocus`.
carbon-design-system · Oct 2, 2024 · 204508f · 204508f
1 parent c0d2b32
commit 204508f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/react/src/components/Tooltip/DefinitionTooltip.tsx b/packages/react/src/components/Tooltip/DefinitionTooltip.tsx
@@ -116,8 +116,10 @@ const DefinitionTooltip: React.FC<DefinitionTooltipProps> = ({
         onBlur={() => {
           setOpen(false);
         }}
-        onClick={() => {
-          setOpen(!isOpen);
+        onMouseDown={(event) => {
+          // We use onMouseDown rather than onClick to make sure this triggers
+          // before onFocus.
+          if (event.button === 0) setOpen(!isOpen);
         }}
         onKeyDown={onKeyDown}
         type="button">