Fix DefinitionTooltip not opening on first click #17622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`onClick` -> `onMouseDown` so the action happens before `onFocus`.
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17622 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 408 408
Lines 13993 13994 +1
Branches 4349 4301 -48
=======================================
+ Hits 10779 10780 +1
- Misses 3041 3042 +1
+ Partials 173 172 -1 ☔ View full report in Codecov by Sentry. |
ariellalgilmore
approved these changes
Oct 1, 2024
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Oct 2, 2024
204508f
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17070
The problem was
onFocusopened the tooltip, then theonClickfrom the same event immediately closed it again.This PR proposes a fix by changing
onClicktoonMouseDown, which occurs beforeonFocus.Changelog
Changed
DefinitionTooltipwithopenOnHover=falseimmediately closed the first time it was clicked.Testing / Reviewing
Open storybook, go to
DefinitionTooltip, setopenOnHovertofalse, then click the component.Screen.Recording.2024-10-01.at.07.43.52.mov