refactor(data-table): DataTable components to use aria-label instead …

…of ariaLabel (#16332) * refactor(data-table): data-table Update to deprecate ariaLabel in favor of aria-label. No breaking changes, aria-label will have priority if provided. * refactor(data-table): data-table add my user as contributor for code and a11y. No changes in the logic compared to last commit * Apply suggestions from code review --------- Co-authored-by: Taylor Jones <[email protected]>
carbon-design-system · Jun 13, 2024 · c35d1c7 · c35d1c7
1 parent 8d27f0e
commit c35d1c7
Show file tree

Hide file tree

Showing 13 changed files with 2,731 additions and 4,250 deletions.
diff --git a/.all-contributorsrc b/.all-contributorsrc
@@ -1542,6 +1542,15 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "digiacomo-a",
+      "name": "Andrea DG",
+      "avatar_url": "https://avatars.githubusercontent.com/u/117646602?v=4",
+      "profile": "https://github.com/digiacomo-a",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "commitConvention": "none"

diff --git a/README.md b/README.md
@@ -291,6 +291,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
     <td align="center"><a href="https://github.com/aninaantony"><img src="https://avatars.githubusercontent.com/u/164350784?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Anina Antony</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=aninaantony" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/ahmedsemih"><img src="https://avatars.githubusercontent.com/u/102798814?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Ahmed Semih Erkan</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=ahmedsemih" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/ychavoya"><img src="https://avatars.githubusercontent.com/u/7907338?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Yael Chavoya</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=ychavoya" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/digiacomo-a"><img src="https://avatars.githubusercontent.com/u/117646602?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Andrea DG</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=digiacomo-a" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/Kilian-Collender"><img src="https://avatars.githubusercontent.com/u/37899503?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Kilian Collender</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Kilian-Collender" title="Code">💻</a></td>
   </tr>
 </table>

diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -2004,10 +2004,10 @@ Map {
     },
     "TableSelectAll": Object {
       "propTypes": Object {
-        "ariaLabel": Object {
-          "isRequired": true,
+        "aria-label": Object {
           "type": "string",
         },
+        "ariaLabel": [Function],
         "checked": Object {
           "isRequired": true,
           "type": "bool",
@@ -2037,10 +2037,10 @@ Map {
     },
     "TableSelectRow": Object {
       "propTypes": Object {
-        "ariaLabel": Object {
-          "isRequired": true,
+        "aria-label": Object {
           "type": "string",
         },
+        "ariaLabel": [Function],
         "checked": Object {
           "isRequired": true,
           "type": "bool",
@@ -8006,10 +8006,10 @@ Map {
   },
   "TableSelectAll" => Object {
     "propTypes": Object {
-      "ariaLabel": Object {
-        "isRequired": true,
+      "aria-label": Object {
         "type": "string",
       },
+      "ariaLabel": [Function],
       "checked": Object {
         "isRequired": true,
         "type": "bool",
@@ -8039,10 +8039,10 @@ Map {
   },
   "TableSelectRow" => Object {
     "propTypes": Object {
-      "ariaLabel": Object {
-        "isRequired": true,
+      "aria-label": Object {
         "type": "string",
       },
+      "ariaLabel": [Function],
       "checked": Object {
         "isRequired": true,
         "type": "bool",

diff --git a/packages/react/examples/custom-data-table-state-manager-vite/package.json b/packages/react/examples/custom-data-table-state-manager-vite/package.json
@@ -22,7 +22,7 @@
     "eslint": "^8.54.0",
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-react-refresh": "^0.4.4",
+    "eslint-plugin-react-refresh": "^0.4.6",
     "sass": "1.69.5",
     "vite": "^5.0.13"
   }

diff --git a/...es/react/examples/custom-data-table-state-manager-vite/src/components/CustomDataTable.jsx b/...es/react/examples/custom-data-table-state-manager-vite/src/components/CustomDataTable.jsx
@@ -204,7 +204,7 @@ const CustomDataTable = ({
                 indeterminate={
                   selectedRowsCountInFiltered > 0 && !selectedAllInFiltered
                 }
-                ariaLabel="Select all rows"
+                aria-label="Select all rows"
                 name={selectionAllName}
                 onSelect={handleChangeSelectionAll}
               />
@@ -247,7 +247,7 @@ const CustomDataTable = ({
                     id={`${elementId}--select-${rowId}`}
                     checked={Boolean(selected)}
                     name={selectionName}
-                    ariaLabel="Select row"
+                    aria-label="Select row"
                     onSelect={handleChangeSelection}
                   />
                 )}