Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: Modal interaction problems #12727

Closed
4 tasks done
mbgower opened this issue Nov 24, 2022 · 4 comments
Closed
4 tasks done

[a11y]: Modal interaction problems #12727

mbgower opened this issue Nov 24, 2022 · 4 comments
Labels
component: modal package: @carbon/react @carbon/react planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@mbgower
Copy link

mbgower commented Nov 24, 2022

Description

This issue covers what I would consider 'bugs' in the modal components. It is complementary to the discussion #12726 I have opened, and contains information based on the Modal component review for accessibiliity. It is complementary to a review of Carbon website guidance carbon-design-system/carbon-website#3312.

Items to address

  1. component: modal role: dev 🤖 severity: 2 type: a11y ♿ type: bug 🐛
    tw15egan
  2. component: modal role: dev 🤖 severity: 3 type: a11y ♿ type: bug 🐛
    tw15egan
  3. component: modal role: dev 🤖 severity: 2 status: waiting for author's response 💬 type: a11y ♿ type: bug 🐛
    tw15egan
  4. component: modal role: dev 🤖 severity: 2 type: a11y ♿ type: bug 🐛
    alisonjoseph

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-modal--with-state-manager

@mbgower
Copy link
Author

mbgower commented Dec 1, 2022

I just encountered a 'modal' dialog in Workday. Obviously not a Carbon component, but a real-life situation helps discuss. (Note that View Details did not have focus when this appeared. That was a result of me tabbing.)

My keyboard was constrained to tabbing between the X button to close and the link to "View details". Even though there was no decision needed on my part, I was forced to intentionally dismiss via keyboard.
However, with a mouse, I could simply click anywhere and the 'modal' disappeared.
In such a situation, it would be easy for the user to not even see the message before dismissing. For a dialog that required interaction, that would be a poor user experience. In this situation (where a response wasn't really needed) the impact is neglibile.
So, should it BE a modal?
And if it isn't a modal, should tabbing away from it dismiss it? Is there any dropback to that interaction?
image

@mbgower
Copy link
Author

mbgower commented Dec 12, 2022

I added issues 7 and 8

@tay1orjones tay1orjones added the severity: 2 https://ibm.biz/carbon-severity label Dec 12, 2022
@sstrubberg sstrubberg removed this from the 2023 Q1 milestone Feb 23, 2023
@mbgower
Copy link
Author

mbgower commented Feb 24, 2023

@sstrubberg , IMO the items marked as Sev 2 remain appropriate for higher priority (issues 1, 2, 5 and 7.2)

@tay1orjones

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: modal package: @carbon/react @carbon/react planning: umbrella Umbrella issues, surfaced in Projects views role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
Archived in project
Development

No branches or pull requests

4 participants