Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: Modal: The 'fade' effect on dialogs with overflow body text creates some odd behaviours #13714

Closed
Tracked by #12727
tay1orjones opened this issue May 2, 2023 · 0 comments · Fixed by #14712
Closed
Tracked by #12727

Comments

@tay1orjones
Copy link
Member

tay1orjones commented May 2, 2023

Originally outlined in #12727:

The Carbon guidance on Overflow is that "The content should visibly fade at the end of the modal body area to indicate there is additional content out of view."

However, scroll bars are already indicating additional content.

There are negative results of this 'fade area':

  1. Especially with forms, the fade affect doesn't really work, so the bottom part of the dialog is effectively a bunch of padding
    image
  2. The fading area has been implemented in a way that makes the browser think it is not within the modal, so if a user clicks inside the dialog in this space, the dialog is dismissed, as if the user had clicked outside it (which, as per issue 3, should only be happening on the passive -- which should never have enough text to need scrolling IMO) Sev 2
    Here is a shot of a dialog with scrolling added to the body, so you can see the area in the dialog affected by this
    Screenshot 2022-12-12 at 6 29 08 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants