Accordion - experimental component (feedback from review)

[laurenmrice]

• hover needs to completely go over the rule lines
• focus needs to be on the whole row, not the chevron (safari doesnt have focus indicator)
• motion updates
• row height is 35px and should be 32px
• line height needs to be 20 not 21px
• fix content padding for mobile view to take up full width up until 16px from svg instead of 75%

[asudoh]

Got quick fix for some, @laurenmrice the light height seems font size (14px) times 1.5, do we want it non-relative to the font size? Also wondering what you meant by the first item. Thanks!

[laurenmrice]

@asudoh Yes the type size is 14px but the line height of spacing should be set at 20px (1.25 rem). The type token for this is body-long-01.

For the first item about hover, currently when you hover over rows, the lines between the rows are showing up ontop of the hover. We want to cover these lines on the row when the hover is activated

[asudoh]

Thanks @laurenmrice for clarifying! Addressed the latter. The former seems to depend on #1546.

[asudoh]

From @laurenmrice (#1674 (review)):

Looks good. But one thing I did notice on the focus states is that the blue outline is within the two line dividers of each row. When the focus is activated, the lines for that row should not be visible.

[carbon-bot]

🎉 This issue has been resolved in version 9.80.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀