Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update border-block-end to use $border-subtle-01 #17548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ziyadzulfikar
Copy link

Closes #17454

Updated the border-block-end of each element in the table rows.

Changelog

Changed

  • Changed border-block-end: 1px solid $border-subtle; to border-block-end: 1px solid $border-subtle-01;

Testing / Reviewing

  • Navigate to the DataTable component's playground story.

  • Review the styling of the <td> elements in the table rows that use the border-block-end property, and ensure the values are applied correctly and consistently.

Copy link
Contributor

github-actions bot commented Sep 22, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c234031
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66efc843d576c1000899402a
😎 Deploy Preview https://deploy-preview-17548--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c234031
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66efc843cbbc860008ab5f7e
😎 Deploy Preview https://deploy-preview-17548--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ziyadzulfikar
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Data table border-subtle is off by a layer
1 participant