-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): update border-block-end to use $border-subtle-01 #17548
fix(styles): update border-block-end to use $border-subtle-01 #17548
Conversation
All contributors have signed the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! There is one small piece still needed though, see below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You just have to fix some merge conflicts
@guidari |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17548 +/- ##
=======================================
Coverage 80.15% 80.15%
=======================================
Files 406 406
Lines 14011 14011
Branches 4332 4384 +52
=======================================
Hits 11231 11231
+ Misses 2614 2613 -1
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
Hey, I'm checking Percy and seems like this changes triggers an error in Datatable story with expansion. The line it is not complete |
@guidari This issue has been fixed.
|
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cool! Percy LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e667c88
Hey there! v11.69.0 was just released that references this issue/PR. |
Closes #17454
Updated the
border-block-end
of each element in the table rows.Changelog
Changed
border-block-end: 1px solid $border-subtle;
toborder-block-end: 1px solid $border-subtle-01;
Testing / Reviewing
Navigate to the DataTable component's playground story.
Review the styling of the
<td>
elements in the table rows that use theborder-block-end
property, and ensure the values are applied correctly and consistently.