Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Number Input]: label default prop causes label to always render then ariaLabel isn't applied #5341

Closed
1 of 2 tasks
abbeyhrt opened this issue Feb 13, 2020 · 0 comments · Fixed by #5347
Closed
1 of 2 tasks

[Number Input]: label default prop causes label to always render then ariaLabel isn't applied #5341

abbeyhrt opened this issue Feb 13, 2020 · 0 comments · Fixed by #5347
Assignees
@abbeyhrt
Labels
component: number-input severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@abbeyhrt
Copy link
Contributor

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Since the label has a default prop of an empty string, the label element is always rendered causing DAP violations if the user only specifies ariaLabel (which should replace a label if they don't want that) and the ariaLabel doesn't get applied.

If you specify an ariaLabel and not a label, these are the violations that causes:
Screen Shot 2020-02-13 at 12 12 23 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbeyhrt abbeyhrt

Labels
component: number-input severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(number-input): remove default value for label
1 participant
@abbeyhrt