fix(number-input): remove default value for label

[abbeyhrt]

Closes #5341

This removes the default prop for label so the label element isn't always rendered, for example if a user wants to label the Number Input with ariaLabel instead.

Changelog

Removed

• label default prop

Testing / Reviewing

Check that if label is empty, no label element is rendered

[netlify]

Deploy preview for carbon-elements ready!

Built with commit 5047ceb

https://deploy-preview-5347--carbon-elements.netlify.com

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit 5047ceb

https://deploy-preview-5347--carbon-components-react.netlify.com

[joshblack]

Looks fine from the diff, what are the implications for removing it? Does any part of the rendered UI change for folks who might be using the default prop?

[asudoh]

@abbeyhrt Would you be able to do some quick testing if setting empty label has the same visual effect as hideLabel? Thanks!

[abbeyhrt]

@joshblack @asudoh in the storybook, it seems to move a 7 pixels down if there is no label present vs hideLabel (this is true before this PR though). There's code that seems to want the label element to not be rendered if there is no label defined but the default prop makes that never happen unless someone deliberately sets label to null. We maybe always wanted this to happen but it's been broken?

    const labelText = label ? (
      <label htmlFor={id} className={labelClasses}>
        {label}
      </label>
    ) : null;

     'aria-label': label ? null : ariaLabel,

[asudoh]

@abbeyhrt To do that, I think we need to ensure the styling of hideLabel is applied to <NumberInput> with empty value. Signing off given @designertyler created an issue to track that.

[tw15egan]

LGTM 👍 ✅