chore(fluid-form): update fluid input styles #13343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aledavila
added
status: ready for review 👀
DO NOT MERGE
and removed
status: ready for review 👀
labels
|
|
aledavila
changed the title
|
@tay1orjones @tw15egan ready for review |
tay1orjones
approved these changes
Mar 16, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13258
Closes #13356
Fluid input styles updates
Changed
Spread only the form content full width inside of the modal.
Updated
FluidTextAreainvalid state outlines to borders.Updated backgrounds for fluid inputs when in modal
Testing / Reviewing
Make sure fluid form content is spread to the full width of modal.
Go to
FluidFormunder experimental. Click on the modal.Pull it down. Add invalid states to the inputs in the modal. Make sure both focus and invalid states are good.