-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(headermenu): added typescript types to headermenu #16116
refactor(headermenu): added typescript types to headermenu #16116
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Just a couple things
taylor's suggestion Co-authored-by: Taylor Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Working as expected after tests
719b5f4
Hey there! v11.55.0 was just released that references this issue/PR. |
…sign-system#16116) * refactor(headermenu): added typescript types to headermenu * Update packages/react/src/components/UIShell/HeaderMenu.tsx taylor's suggestion Co-authored-by: Taylor Jones <[email protected]> * refactor(headermenu): changed customclassname to string literal * refactor(headermenu): added proptype comments to interface --------- Co-authored-by: Taylor Jones <[email protected]>
Closes #13589
Added typescript types for HeaderMenu component
Changelog
New
Changed
Testing / Reviewing
Opened new PR as #16104 had commits which were unrelated.
No new observations from testing perspective.