-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slider): set null check for value in slider #16157
fix(slider): set null check for value in slider #16157
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
recheck |
From the linked issue #16141:
Did you find this to be the case? What's the best way to test this and validate that it is fixed? |
As mentioned in the bug, within the storybook playground, when I gave a negative minimum value (-100) and the slider value as 0, the slider was positioned towards the left side, as illustrated below. However, with the fix mentioned , the value 0 is now correctly positioned as shown below. |
# Conflicts: # .all-contributorsrc # README.md
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
342e7f3
Closes #16141
Handling null check for value when the slider has a negative minimum value
Changelog
New
Changed
Added null check for value when the slider has a negative minimum value
Removed
Testing / Reviewing
Slider component - value when slider has negative minimum value