Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tile): update Tile AI styles to phase 3 spec #16183

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

tw15egan
Copy link
Member

Closes #15946

Updates AI Tile to phase 3 spec

Changelog

Changed

  • Adjusted a few drop shadows, removed underline when clickable tile is focused / hovered

Testing / Reviewing

Ensure Tile matches AI phase 3 spec

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b6c0186
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66197a0ba515ab0008b253ac
😎 Deploy Preview https://deploy-preview-16183--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gradient is bleeding to high in the tile, I can't tell where the problem is coming from though.
image

@tw15egan
Copy link
Member Author

tw15egan commented Apr 12, 2024

@aagonzales, we added the 15% stop for the hover gradient mixin; perhaps we need to add it to the base one as well? Just be aware that this is the same gradient background as the callout (Tile just uses $layer as the background), so it would also affect that gradient.

@aagonzales
Copy link
Member

@tw15egan ok, can you add it and I'll check both to make sure it still looks ok.

@tw15egan
Copy link
Member Author

@aagonzales updated. If that doesn't work, we can always break the Tile into it's own gradient like we did with DataTable

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that did it, it looks right to me now. Work fine for callout too.

@alisonjoseph alisonjoseph added this pull request to the merge queue Apr 15, 2024
Merged via the queue into carbon-design-system:main with commit f7ce9e0 Apr 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AI] Phase 3: update tile component to new visuals
4 participants