Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headermenu): headermenu typing corrected #16191

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix(headermenu): headermenu typing corrected #16191

merged 2 commits into from
Apr 15, 2024

Conversation

Gururajj77
Copy link
Contributor

@Gururajj77 Gururajj77 commented Apr 12, 2024 •
edited
Loading

Closes #16181

HeaderMenu typing has been inferred to the forwardRef props

Changelog

New

  • No new code added

Changed

  • Added HeaderMenuProps typing to the fowardRef props

Removed

  • removed menuLinkName prop from the forwardRef HeaderMenu component

Testing / Reviewing

Test with tsx preferred.

@Gururajj77 Gururajj77 requested a review from a team as a code owner April 12, 2024 15:59
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a7df626
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/661d52b014dbdb000822e8e6
😎 Deploy Preview https://deploy-preview-16191--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

guidari
guidari approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tay1orjones tay1orjones added this pull request to the merge queue Apr 15, 2024
Merged via the queue into carbon-design-system:main with commit df51fc5 Apr 15, 2024
20 checks passed
@Gururajj77 Gururajj77 deleted the headermenu-typing branch June 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@guidari guidari guidari approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: HeaderMenu typings are incorrect
3 participants
@Gururajj77 @tay1orjones @guidari