Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multiselect): new All option for multiselect #16236

Merged
merged 62 commits into from
Aug 30, 2024
Merged

feat(multiselect): new All option for multiselect #16236

merged 62 commits into from
Aug 30, 2024

Commits on Apr 18, 2024

  1. feat: Add selectAll option in Multiselect

    @preetibansalui
    preetibansalui committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1689661 View commit details
    Browse the repository at this point in the history

  2. disabled items and length corrected

    @Gururajj77
    Gururajj77 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5d94668 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. changes for select all

    @Gururajj77
    Gururajj77 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9e2dfaf View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. changes

    @Gururajj77
    Gururajj77 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a7ba8b4 View commit details
    Browse the repository at this point in the history

  2. feat(multiselect): unifinshed functionality on the multiselect

    @Gururajj77
    Gururajj77 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9616225 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix: select all option when all items are selected

    @preetibansalui
    preetibansalui committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3ba9e19 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    225c716 View commit details
    Browse the repository at this point in the history

  3. feat(multiselect): using filteredItems from prev changes

    @Gururajj77
    Gururajj77 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ca58748 View commit details
    Browse the repository at this point in the history

  4. fix: added intermediate checkbox icon

    @preetibansalui
    preetibansalui committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    09b4c0e View commit details
    Browse the repository at this point in the history

  5. fix: fixed All option should not be in active state as per design

    @preetibansalui
    preetibansalui committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    beedba5 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. feat(multiselect): tests and avt fixed

    @Gururajj77
    Gururajj77 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f625231 View commit details
    Browse the repository at this point in the history

  2. fix: added prop for selectall option and changed css for all option

    @preetibansalui
    preetibansalui committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d04135c View commit details
    Browse the repository at this point in the history

  3. feat(multiselect): modified avt for default

    @Gururajj77
    Gururajj77 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    028028a View commit details
    Browse the repository at this point in the history

  4. feat: test fixed

    @Gururajj77
    Gururajj77 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ea5681f View commit details
    Browse the repository at this point in the history

  5. feat: added test case for select all

    @Gururajj77
    Gururajj77 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    04ca9e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. fix: format issue

    @preetibansalui
    preetibansalui committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    698f11a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. feat(multiselect): added missed proptypes and typescript types

    @Gururajj77
    Gururajj77 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    256e72e View commit details
    Browse the repository at this point in the history

  2. feat: updated tests

    @Gururajj77
    Gururajj77 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    dc25278 View commit details
    Browse the repository at this point in the history

  3. feat: fixing the build

    @Gururajj77
    Gururajj77 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b8bf158 View commit details
    Browse the repository at this point in the history

  4. feat: updates for test success

    @Gururajj77
    Gururajj77 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ebe3ca1 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored May 7, 2024
    Configuration menu
    Copy the full SHA
    404fced View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. feat: changes according to review comments(except tests)

    @Gururajj77
    Gururajj77 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d93fb79 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. feat: fixed hasSelectAll and added warning

    @Gururajj77
    Gururajj77 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6efeca5 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. feat: made hasselectall prop experimental

    @Gururajj77
    Gururajj77 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d0b1576 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'main' into multiselect-feat

    @preetibansalui
    preetibansalui authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c80b250 View commit details
    Browse the repository at this point in the history

  2. fix: removed duplicate OnChangeData

    @preetibansalui
    preetibansalui committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9f1269b View commit details
    Browse the repository at this point in the history

  3. feat: ran yarn test

    @Gururajj77
    Gururajj77 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    aadeef8 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'main' into multiselect-feat

    @preetibansalui
    preetibansalui authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    33da11e View commit details
    Browse the repository at this point in the history

  2. fix: should deselect all on click to indeterminate icon

    @preetibansalui
    preetibansalui committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a082b01 View commit details
    Browse the repository at this point in the history

  3. chore: added a new story for selectAll and a prop for selectAll label

    @preetibansalui
    preetibansalui committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c3a9bee View commit details
    Browse the repository at this point in the history

  4. fix: active state of selectAll option

    @preetibansalui
    preetibansalui committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b3f48fc View commit details
    Browse the repository at this point in the history

  5. fix: changed items to match with documentation

    @preetibansalui
    preetibansalui committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1519919 View commit details
    Browse the repository at this point in the history

  6. fix: update snapshot

    @preetibansalui
    preetibansalui committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    23363fc View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. fix: alignment issue

    @preetibansalui
    preetibansalui committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ca69bc5 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. fix: firefox issue

    @preetibansalui
    preetibansalui committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5b9107f View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2853da2 View commit details
    Browse the repository at this point in the history

  2. feat: format run

    @Gururajj77
    Gururajj77 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5508689 View commit details
    Browse the repository at this point in the history

  3. feat: fixed storybook

    @Gururajj77
    Gururajj77 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    675af07 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5720baa View commit details
    Browse the repository at this point in the history

  2. feat: formatting ci fail fix

    @Gururajj77
    Gururajj77 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d5e1535 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. feat: select all is exempt from sorting

    @Gururajj77
    Gururajj77 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    bac4ada View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multiselect-feat

    @tay1orjones
    tay1orjones authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    08119aa View commit details
    Browse the repository at this point in the history

  3. chore: remove isSelectAll from ListBoxMenuItem

    @tay1orjones
    tay1orjones committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    13ba415 View commit details
    Browse the repository at this point in the history

  4. chore: update prop names

    @tay1orjones
    tay1orjones committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2f236f8 View commit details
    Browse the repository at this point in the history

  5. chore: rename variables

    @tay1orjones
    tay1orjones committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    624fc1e View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. feat: changed from prop to object property

    @Gururajj77
    Gururajj77 committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7c691f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. fix: focus issue

    @preetibansalui
    preetibansalui committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c2e0649 View commit details
    Browse the repository at this point in the history

  2. fix: remove console

    @preetibansalui
    preetibansalui committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    584cfa8 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2f6e1a4 View commit details
    Browse the repository at this point in the history

  2. feat: fixed tests

    @Gururajj77
    Gururajj77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a162c66 View commit details
    Browse the repository at this point in the history

  3. feat: fixed typing test

    @Gururajj77
    Gururajj77 committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0b5fb7c View commit details
    Browse the repository at this point in the history

  4. fix: focus issue

    @preetibansalui
    preetibansalui committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    fc8641c View commit details
    Browse the repository at this point in the history

  5. Update packages/styles/scss/components/multiselect/_multiselect.scss 

    Co-authored-by: kennylam <[email protected]>
    @Gururajj77 @kennylam
    Gururajj77 and kennylam authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    af158c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5a34364 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. fix: sort issue resolved

    @preetibansalui
    preetibansalui committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0816deb View commit details
    Browse the repository at this point in the history

  2. fix: test case

    @preetibansalui
    preetibansalui committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5f082b6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into multiselect-feat

    @preetibansalui
    preetibansalui authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    85177dc View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0a3ae2e View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'main' into multiselect-feat

    @Gururajj77
    Gururajj77 authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d76cec9 View commit details
    Browse the repository at this point in the history

  2. fix: alignment issue

    @preetibansalui
    preetibansalui committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    03d6457 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. test(multiselect): refactor assertions off data attributes

    @tay1orjones
    tay1orjones committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    38e2798 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multiselect-feat

    @tay1orjones
    tay1orjones authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c9536a7 View commit details
    Browse the repository at this point in the history