Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v11.56.0-rc.1 #16239

Merged
merged 1 commit into from
Apr 22, 2024
Merged

chore(release): v11.56.0-rc.1 #16239

merged 1 commit into from
Apr 22, 2024

Conversation

carbon-automation[bot]
Copy link
Contributor

Automated release PR for v11.56.0-rc.1

Checklist

  • Verify package version bumps are accurate
  • Verify CI passes as expected

@carbon-automation carbon-automation bot requested a review from a team as a code owner April 22, 2024 13:57
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 42358bf
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66266cb95f9c630008adebac
😎 Deploy Preview https://deploy-preview-16239--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisonjoseph are we expecting @carbon/styles to be desynced from the @carbon/react version?

packages/react/package.json Show resolved Hide resolved
packages/react/package.json Show resolved Hide resolved
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a possibility we could see a change to @carbon/styles in the next couple days which would keep the versions in sync

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually going to double check on this - it looks like these should be synced still based on what's changed since the last couple tags

@tay1orjones tay1orjones mentioned this pull request Apr 22, 2024
2 tasks
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a test run of the next stable minor, #16244 proves that everything will properly move to v11.56.0 (v1.56.0) when we publish it in two days.


Full explanation:

When v11.56.0-rc.0 was generated there were no changes to @carbon/styles since the previous version, v11.55.0. So @carbon/react was bumped to v1.56.0-rc.0 and @carbon/styles wasn't bumped at all and stayed on v1.55.0.

Here we're doing a second prerelease in this release cycle - v11.56.0-rc.1. There have been changes to @carbon/styles since the previous release, and so lerna did bump it. I'm not sure why but it only bumped @carbon/styles with a patch instead of a minor, maybe due to the default way lerna is calculating which type of bump should be made when only prerelease is specified.

@alisonjoseph alisonjoseph added this pull request to the merge queue Apr 22, 2024
@tay1orjones tay1orjones removed this pull request from the merge queue due to a manual request Apr 22, 2024
@tay1orjones tay1orjones merged commit c6ef02e into main Apr 22, 2024
20 checks passed
@tay1orjones tay1orjones deleted the release/v11.56.0-rc.1 branch April 22, 2024 18:50
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants