fix(timepicker): stopped disabled prop from TimePicker overriding the TimePickerSelect's disabled prop
#16324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gururajj77
changed the title
disabled prop from TimePicker overriding the TimePickerSelect's disabled prop
Gururajj77
changed the title
disabled prop from TimePicker overriding the TimePickerSelect's disabled propdisabled prop from TimePicker overriding the TimePickerSelect's disabled prop
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
May 7, 2024
Merged
via the queue into
carbon-design-system:main
with commit May 7, 2024
02588c6
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16246
Stopped TimePicker's
disabledprop overriding the TimePickerSelectdisabledpropChangelog
Changed
disabledprop while passing it to child, to check whether the user has passed the disabled prop forTimePickerSelectTesting / Reviewing
Test the component by disabling TimePicker and TimePickerSelect separately and observe the functionality to be intact or not.