Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): update storybook-addon-accessibility-checker #16362

Merged
merged 1 commit into from
May 10, 2024

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 8, 2024

This should fix the browser console error we sometimes see in storybook where "the id starts with a number..."

Changelog

Changed

  • update storybook-addon-accessibility-checker to latest version

Testing / Reviewing

  • Poke around in storybook and check the a11y addon to make sure it still works as expected and nothing in the storybook environment has been impacted

Copy link

netlify bot commented May 8, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 02d597e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/663bd92f39870a00090b4fa2
😎 Deploy Preview https://deploy-preview-16362--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clicked through a few stories and a11y checker seemed good

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stories are looking normal

@guidari guidari added this pull request to the merge queue May 10, 2024
Merged via the queue into carbon-design-system:main with commit 5568dc9 May 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants